[dev] [st] solarized light patch colors incorrect

[Egmont Koblinger]

Hi,

I came across patches for the Solarized color scheme under
https://st.suckless.org/patches/solarized/ .

I wuold like to point out that the "light" variant, along with its
screenshot, is incorrect.

According to the Solarized homepage
https://ethanschoonover.com/solarized/ , the section "The Values",
each of the 0-15 indices have a corresponding fixed RGB value. There's
not a single word about reversing the order of base03..base3.

Underneath, the section "Usage & Development" also illustrates that
the RGB definition of base03 and friends do not change. It is the
responsibility of applications to emit reversed values if that's what
makes sense for them, according to whether they wish to use the dark
or light variant. (And above, under Features -> Precision & Symmetry
this is demonstrated as a sass (scss) snippet, but that's unrelated to
terminal emulation and the concept of indices 0-15, it corresponds to
what let's say "vim" would probably also do when implementing a dark
solarized and a light solarized pair of skins.)

In the two variants, the palette of 16 should be identical. It is only
defaultfg and defaultbg that should differ.


cheers,
egmont

[Silvan Jegen]

Hi

Post by Egmont Koblinger
I came across patches for the Solarized color scheme under
https://st.suckless.org/patches/solarized/ .
I wuold like to point out that the "light" variant, along with its
screenshot, is incorrect.
According to the Solarized homepage
https://ethanschoonover.com/solarized/ , the section "The Values",
each of the 0-15 indices have a corresponding fixed RGB value. There's
not a single word about reversing the order of base03..base3.
Underneath, the section "Usage & Development" also illustrates that
the RGB definition of base03 and friends do not change. It is the
responsibility of applications to emit reversed values if that's what
makes sense for them, according to whether they wish to use the dark
or light variant. (And above, under Features -> Precision & Symmetry
this is demonstrated as a sass (scss) snippet, but that's unrelated to
terminal emulation and the concept of indices 0-15, it corresponds to
what let's say "vim" would probably also do when implementing a dark
solarized and a light solarized pair of skins.)
In the two variants, the palette of 16 should be identical. It is only
defaultfg and defaultbg that should differ.

Patches welcome!


Cheers,

Silvan

[Egmont Koblinger]

Hi Silvan,

Post by Silvan Jegen
Patches welcome!

My sole intent was to report a bug, leaving it up to you how you handle it.

Thanks for your understanding,
egmont

Post by Silvan Jegen
Hi

Post by Egmont Koblinger
I came across patches for the Solarized color scheme under
https://st.suckless.org/patches/solarized/ .
I wuold like to point out that the "light" variant, along with its
screenshot, is incorrect.
According to the Solarized homepage
https://ethanschoonover.com/solarized/ , the section "The Values",
each of the 0-15 indices have a corresponding fixed RGB value. There's
not a single word about reversing the order of base03..base3.
Underneath, the section "Usage & Development" also illustrates that
the RGB definition of base03 and friends do not change. It is the
responsibility of applications to emit reversed values if that's what
makes sense for them, according to whether they wish to use the dark
or light variant. (And above, under Features -> Precision & Symmetry
this is demonstrated as a sass (scss) snippet, but that's unrelated to
terminal emulation and the concept of indices 0-15, it corresponds to
what let's say "vim" would probably also do when implementing a dark
solarized and a light solarized pair of skins.)
In the two variants, the palette of 16 should be identical. It is only
defaultfg and defaultbg that should differ.

Patches welcome!
Cheers,
Silvan

[Quentin Rameau]

Post by Egmont Koblinger
My sole intent was to report a bug, leaving it up to you how you handle it.

Thank you consumer, please forward to your nearest Apple Store Geniuses

[Peter Nagy]

Is it a crime to be a consumer? Do you really suggest him to go buy an Apple product just because he won't contribute code? I don't think I read about elitism in the suckless philosophy pages.
--
Peter Nagy

- To reach a goal one has to enjoy the journey

Post by Egmont Koblinger

Post by Egmont Koblinger
My sole intent was to report a bug, leaving it up to you how you

handle it.
Thank you consumer, please forward to your nearest Apple Store Geniuses

[Alexander Krotov]

Post by Peter Nagy
Is it a crime to be a consumer? Do you really suggest him to go buy an Apple product just because he won't contribute code? I don't think I read about elitism in the suckless philosophy pages.

From https://dwm.suckless.org/:
"Because dwm is customized through editing its source code, it’s
pointless to make binary packages of it. This keeps its userbase small
and elitist. No novices asking stupid questions. There are some
distributions that provide binary packages though."

[Egmont Koblinger]

Whoa whoa whoa... could we stop here for a sec, please?

First of all, before filing this bugreport I checked suckless's
homepage, which says on its Community page: "***@suckless.org - for
dwm/dmenu/st/… users, development discussion, bug reports and general
discussion". I did look up that this is the forum that suckless
developres picked for bugreports. Now do you say that bugreports
aren't welcome? Then this page should be fixed (I guess I should send
a patch, right?).

Second, I'd like to seriously understand: Do you believe that a
bugreport (without a patch) has zero, or perhaps even negative value?
If you think it still has a positive value, no matter how small it is,
a "thanks" (or no response at all) would have been a much better
reaction.

Third: I don't recall being rude to you, or demanding you to fix this
bug, I only informed you about one. I just don't find your attitude
justified at all. I wasn't sure how to interpret Silvan's words, they
could have easily been interpreted as rude, but I assumed good intent
(indeed, I know that a bugreport with patch is much better than one
without), hence my respnose clarifying the situation. But your comment
is surely way out of line.

Fourth: Guess what, I am a developer myself, having contributed a lot
to (and as of now also working on) open source in my free time. I just
don't find the model of cross-fixing each other's bugs a good one. You
know what: I often fix bugs reported by others in the product I'm
developing, and never occurs to me to respond to anyone like this. I
firmly believe it's a more effective model if people preferably work
with the code base and surrounding infrastructure that they're more
familiar with. Read: You're free to report bugs against my project
(minding the style, of course), and I fix the ones in mine, you fix
the ones in yours, rather than the other way around.

Fifth: Not sure if you're affiliated with suckless or just randomly
commenting, but the combination of this style, having to use a mailing
list rather than a bug tracker software, and coming across a tiny
patch that so far 7 people worked on and is still conceptually buggy,
makes it absolutely clear to me that suck "less" is an utter lie.
(Unless you mean "sucks less for the project's developers").

I'm happy to unsubscribe from your list now and never to come back. It
was a pleasure.

wishing all of you the best,
egmont

Post by Quentin Rameau

Post by Egmont Koblinger
My sole intent was to report a bug, leaving it up to you how you handle it.

Thank you consumer, please forward to your nearest Apple Store Geniuses

[Quentin Rameau]

Post by Egmont Koblinger
Whoa whoa whoa... could we stop here for a sec, please?

WOW!!

Post by Egmont Koblinger
First of all, before filing this bugreport I checked suckless's
dwm/dmenu/st/… users, development discussion, bug reports and general
discussion". I did look up that this is the forum that suckless
developres picked for bugreports. Now do you say that bugreports
aren't welcome? Then this page should be fixed (I guess I should send
a patch, right?).

I say that bug reports should be accompagned with a patch (yes please).

Post by Egmont Koblinger
Second, I'd like to seriously understand: Do you believe that a
bugreport (without a patch) has zero, or perhaps even negative value?
If you think it still has a positive value, no matter how small it is,
a "thanks" (or no response at all) would have been a much better
reaction.

You forgot to say “IMHO”.
I think that it depends on what the bug report is pointed at.

Post by Egmont Koblinger
Third: I don't recall being rude to you, or demanding you to fix this
bug, I only informed you about one. I just don't find your attitude
justified at all. I wasn't sure how to interpret Silvan's words, they
could have easily been interpreted as rude, but I assumed good intent
(indeed, I know that a bugreport with patch is much better than one
without), hence my respnose clarifying the situation. But your comment
is surely way out of line.

Which line?

Post by Egmont Koblinger
Fourth: Guess what, I am a developer myself, having contributed a lot
to (and as of now also working on) open source in my free time. I just
don't find the model of cross-fixing each other's bugs a good one. You
know what: I often fix bugs reported by others in the product I'm
developing, and never occurs to me to respond to anyone like this. I
firmly believe it's a more effective model if people preferably work
with the code base and surrounding infrastructure that they're more
familiar with. Read: You're free to report bugs against my project
(minding the style, of course), and I fix the ones in mine, you fix
the ones in yours, rather than the other way around.

Congratulations.

Post by Egmont Koblinger
Fifth: Not sure if you're affiliated with suckless or just randomly
commenting, but the combination of this style, having to use a mailing
list rather than a bug tracker software, and coming across a tiny
patch that so far 7 people worked on and is still conceptually buggy,
makes it absolutely clear to me that suck "less" is an utter lie.
(Unless you mean "sucks less for the project's developers").

It doesn't matter if I am or not.
Good, I think you're starting to understand why bug reports without
action about such patches are welcomed this way.

Post by Egmont Koblinger
I'm happy to unsubscribe from your list now and never to come back. It
was a pleasure.

Yes, that's one way to exercise your consumer's rights.

Post by Egmont Koblinger
wishing all of you the best,

Thank you, to you too.

[David Demelier]

Post by Quentin Rameau
I say that bug reports should be accompagned with a patch (yes
please).

Quentin, I agree that patches are welcome, for the colors I understand
that is a easy issue that could be fixed by any newcomer.

However, not everybody can fix everything. For example, I use dwm but
if I find a bug within I'm pretty sure I'll unable to fix it (example I
remember the old SDL issue regarding fullscreen), mostly because I
don't know X11 libraries not because I would not do it. So I think we
can't just ask everyone to provide a patch every single time they
encounter a bug.

Everybody make mistakes and errors and asking others to fix them for
you is a bit rude IMHO. It's like:

- I have found a very small bug in your application
- Just fix it yourself, it's my mistake but it's only you that want it
to be fixed.

Regards,

[Quentin Rameau]

Post by David Demelier
However, not everybody can fix everything.

Yes they can. If they want to.

Post by David Demelier
For example, I use dwm but
if I find a bug within I'm pretty sure I'll unable to fix it (example I
remember the old SDL issue regarding fullscreen), mostly because I
don't know X11 libraries not because I would not do it. So I think we
can't just ask everyone to provide a patch every single time they
encounter a bug.

We can, and I do.

Post by David Demelier
Everybody make mistakes and errors and asking others to fix them for
- I have found a very small bug in your application
- Just fix it yourself, it's my mistake but it's only you that want it
to be fixed.

It's now clear you got it backwards.
I'm not asking anybody to fix errors for me, the whole point is that
it's the other way aroud I'm against.

And no, it's not my mistake, stop pointing fingers, especially at the
wrong persons.
If you had read the thread correctly, it's about a third party patch.
I didn't write it, the name of the author is accessible.

Please stop wasting time and do something useful with it.

Thank you for your unsolicited opinion, though.

(I hope this wasn't too rude IYHO)

[David Demelier]

Post by Quentin Rameau
And no, it's not my mistake, stop pointing fingers, especially at the
wrong persons.
If you had read the thread correctly, it's about a third party patch.
I didn't write it, the name of the author is accessible.

I have never told it's you, I'm just commenting the quote

I say that bug reports should be accompagned with a patch (yes
please).

[opal hart]

Post by Egmont Koblinger

Post by Egmont Koblinger
My sole intent was to report a bug, leaving it up to you how you

handle it.
Thank you consumer, please forward to your nearest Apple Store
Geniuses

And you would reply the same way to a security-related bug report without a patch?

Grow up, quinq. If you don't have anything good to say about a bug report then don't say anything at all.

[Quentin Rameau]

Post by opal hart
And you would reply the same way to a security-related bug report without a patch?

I would reply in a worse way, according to your standards (if I
understand correctly).
Third‐party patches are what they are. If you don't read and/or
understand what you apply, you're on your own.

Post by opal hart
Grow up, quinq. If you don't have anything good to say about a bug report then don't say anything at all.

Thank you grown up for saying something meaningful.

[opal hart]

Post by Quentin Rameau
Third‐party patches are what they are. If you don't read and/or
understand what you apply, you're on your own.

"We don't support third-party patches, fix it yourself or contact the person who developed the patch." That wasn't hard to say.

It's your role to make not only the code, but also the community, suck less. Else nobody is really living up to the name, right?

[Quentin Rameau]

Post by opal hart

Post by Quentin Rameau
Third‐party patches are what they are. If you don't read and/or
understand what you apply, you're on your own.

"We don't support third-party patches, fix it yourself or contact the person who developed the patch." That wasn't hard to say.

I'm glad you got it.

Post by opal hart
It's your role to make not only the code, but also the community, suck less. Else nobody is really living up to the name, right?

You convinced me, let me embrace the producer-consumer
community lifestyle.
I'll shut up and listen to people telling how things should be done
instead of doing them.
I already feel enlightened (and grown up).

[opal hart]

So, back to that question about security-related bug reports. You haven't commented.

[Quentin Rameau]

Post by opal hart
So, back to that question about security-related bug reports. You haven't commented.

Maybe it's a misplaced consumer^Wgrown up habbit which makes you feel
like your entitled to a comment?

If you had the decency to at least read the answers to the questions
for which you demand an answer, you'd had seen I already did.

I will happily review any patch fixing a security™-related issue you
send us, but until then you're just (starting to) wasting time.

Until then, I'll go back to other things, good luck!

[opal hart]

Post by Quentin Rameau
Maybe it's a misplaced consumer^Wgrown up habbit which makes you feel
like your entitled to a comment?

It's called making conversation

Post by Quentin Rameau
If you had the decency to at least read the answers to the questions
for which you demand an answer, you'd had seen I already did.
I would reply in a worse way,
I will happily review any patch fixing a security™-related issue you
send us

so I'm glad I asked twice. You can't even agree with yourself.

[Silvan Jegen]

Post by Egmont Koblinger
Hi Silvan,

Post by Silvan Jegen
Patches welcome!

My sole intent was to report a bug, leaving it up to you how you handle it.

I should have thanked you for your bug report too. Thanks for that!

I am just afraid that if you won't take the time to fix it, no one else will...


Cheers,

Silvan

[Cág]

I am currently LOL'ing @ the thread.

It ain't no CVE, it's a freakin color scheme crap. Found a bug -> fix
the damn thing. Don't need no MS in CS.

--
caóc

[opal hart]

Post by Cág
It ain't no CVE, it's a freakin color scheme crap. Found a bug -> fix
the damn thing. Don't need no MS in CS.
--
caóc

Look at any other dev project and you'll see that this is a childish display no matter the implications of the bug.

I'm glad you social misfits found a place you feel like you can belong.

[Cág]

Post by opal hart
Look at any other dev project and you'll see that this is a childish
display no matter the implications of the bug.

suckless is not your average dev project. You are supposed to know
something before using it. You and OP are being petty and lazy, because
instead of writing a sub-30-lines patch that doesn't even envolve any
programming -- you can't call changing hex color codes `programming', --
and pushing it to the wiki that is open for everyone, you write rants
and essays on how people here are meanies and your fee-fees hurt.

Quentin wasn't even rude, and never insulted anyone.

It's not like suckless is something you can't avoid, it's not
GTK+/GNOME, Firefox, systemd etc.

--
caóc